Ethereal-dev: Re: [Ethereal-dev] [PATCH] Fields for PDU types in COTP packet-clnp.patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 1 Jul 2004 01:41:35 -0700
On Thu, Jul 01, 2004 at 09:31:10AM +0100, matthew.bradley@xxxxxxxxxxxxx wrote:
> Please find attached a patch against the latest packet-clnp.c. If adds
> fields for cotp.type.XX where XX is the TPDU type: CR, CC, AK, DT etc. This
> allows easy filtering and searching.
> 
> The patch sets the field type for the TPDU type fields to FT_NONE.

Why?  That's the wrong type for something that you want to filter on, as
it doesn't have a value assigned to it.

Does filtering on

	cotp.type == CR

not find packets of type CR?  If it does, why is cotp.type.CR needed
(other than saving 3 characters in the filter expression - you can
reduce that to one character with

	cotp.type==CR

)?  If it doesn't, that's a bug.