Ethereal-dev: [Ethereal-dev] Re: [Ethereal-cvs] cvs commit: ethereal/gtk proto_draw.c rtp_anal

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Ulf Lamping" <ulf.lamping@xxxxxx>
Date: Wed, 30 Jun 2004 09:12:12 +0200
ethereal-dev@xxxxxxxxxxxx schrieb am 30.06.04 08:59:28:
> 
> guy         2004/06/30 01:58:59 CDT
> 
>   Modified files:
>     gtk                  proto_draw.c rtp_analysis.c 
>   Log:
>   On at least some platforms, a #define of O_BINARY is needed even if
>   <fcntl.h> is included, as <fcntl.h> doesn't define it.
>   

What do you mean with some platforms? Some windows platforms?

The MSDN states, that fcntl.h will include O_BINARY.

The comment :

/* Win32 needs the O_BINARY flag for open() */

should be changed to something more appropriate, like:

/* Some platforms needs the O_BINARY flag for open() */

As the current comment is simply wrong otherwise.

And please note, that O_BINARY on Win32 is defined as 0x8000, so defining it as 0 will probably cause problems.

Regards, ULFL

_______________________________________________________
WEB.DE Video-Mail - Sagen Sie mehr mit bewegten Bildern
Informationen unter: http://freemail.web.de/?mc=021199