Ethereal-dev: Re: [Ethereal-dev] H235 & ASN1 compiler

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Tomas Kukosa <tomas.kukosa@xxxxxxxxxxx>
Date: Fri, 04 Jun 2004 10:41:10 +0200
It seems that solution with the NO_EMIT directive in the conformation file was not the right one. It disables dissector function emitting but relations remains and subtypes and fields are emitted. The new directive OMIT_ASSIGNMENT was introduced so as not to process assignment anymore.

The patches for the H235 dissector and the ASN1 compiler are attached.

Changes in the asn2eth compiler:
- new directive OMIT_ASSIGNMENT in conformation file - avoids assignment processing
- support of SEQUENCE OF, SET, SET OF for BER was fixed

Changes in the H235:
 - unnecessary types are excluded with OMIT_ASSIGNMENT directive instead of NO_EMIT one


 Regards,
   Tomas

Guy Harris wrote:

On Thu, Jun 03, 2004 at 01:37:22AM -0700, Guy Harris wrote:

On Mon, May 31, 2004 at 11:00:22AM +0200, Tomas Kukosa wrote:

The patches for the H235 dissector and the ASN1 compiler are attached.

Checked in.


And "packet-h235.c", generated from the new code, has also been checked
in.

Some warnings from it:

../packet-h235.c: At top level:
../packet-h235.c:236: warning: `dissect_hf_h235_mrandom' defined but not used
../packet-h235.c:239: warning: `dissect_hf_h235_srandom' defined but not used
../packet-h235.c:242: warning: `dissect_hf_h235_responseRandom' defined but not used
../packet-h235.c:245: warning: `dissect_hf_h235_requesterRandom' defined but not used
../packet-h235.c:248: warning: `dissect_hf_h235_requestRandom' defined but not used
../packet-h235.c:278: warning: `dissect_hf_h235_generalId' defined but not used
../packet-h235.c:293: warning: `dissect_hf_h235_keyMaterial' defined but not used
../packet-h235.c:434: warning: `dissect_hf_h235_r' defined but not used
../packet-h235.c:437: warning: `dissect_hf_h235_s' defined but not used
../packet-h235.c:724: warning: `dissect_hf_h235_encrptval' defined but not used
../packet-h235.c:765: warning: `dissect_hf_h235_signature' defined but not used
../packet-kerberos.c: In function `dissect_krb5_SignedData':
../packet-kerberos.c:1360: warning: unused parameter `pinfo'
../packet-kerberos.c:1360: warning: unused parameter `tree'
../packet-kerberos.c:1360: warning: unused parameter `tvb'
../packet-pktc.c: In function `dissect_pktc_appspecificdata':
../packet-pktc.c:439: warning: unused parameter `pinfo'
../packet-pktc.c:439: warning: unused parameter `tvb'
../packet-pktc.c:439: warning: unused parameter `tree'

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev


--
_________________________________________________

ANF DATA              ANF DATA spol. s r. o.
a SIEMENS Company     M-palác, Heršpická 5
                      639 00 Brno
                      Czech Republic
Tomáš Kukosa          Tel.: +420 - 5 4310 6822
PSE ECT AES 6         Fax: +420 - 5 4324 8780
Room: 8.24            mailto:tomas.kukosa@xxxxxxxxxxx
_________________________________________________

Attachment: h235.cnf.diff.gz
Description: GNU Zip compressed data

Attachment: asn2eth.py.diff.gz
Description: GNU Zip compressed data