Ethereal-dev: Re: [Ethereal-dev] [PATCH] descriptive RTP Payload Type

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Wed, 2 Jun 2004 00:03:55 -0700
On Tue, Jun 01, 2004 at 01:49:55PM +0200, Thomas Anders wrote:
> With the attached patches packet-sdp.c dissects the RTP Payload Type
> (if media protocol is RTP/AVP) with its descriptive name rather than the
> raw value string, much like packet-rtp.c does already. To avoid duplicate
> definitions, I moved the existing rtp_payload_type_vals[] definition from
> packet-rtp.c and gtk/rtp_stream_dlg.c to rtp_pt.h and used that everywhere.

Actually, the definition should be left in "packet-rtp.c" (or moved to
some other ".c" file), with just a declaration in "rtp_pt.h" -
otherwise, you get multiple copies of the table, and you get compiler
warnings with GCC in all files that include "rtp_pt.h" but don't use the
table.

I've checked in a change to do that.