["Guy Harris" <gharris@xxxxxxxxx>]

Olivier Biot said:
> sys:1: DeprecationWarning: Non-ASCII character '\x96' in file
> ../../tools/asn2eth.py on line 25, but no encoding declared; see
> http://www.python.org/peps/pep-0263.html for details

That's in a comment - it's probably some Windows character set dash/hyphen.

> If I copy the 2 generated files packet-h235.[ch] to ../.. and compile
> Ethereal, I then get a compiler warning and a resulting linker error
> since packet-h235.c contains a NOT_DECODED_YET macro which does not
> exist anymore in PER/BER, as it has been replaced with
> PER_NOT_DECODED_YET/BER_NOT_DECODED_YET. The question is whether this
> should be fixed in packet-h235-template.c or in the asn2eth.py script?

"packet-h235-template.c", as that's the one generating the NOT_DECODED_YET
call.

The one in "asn2eth.py" might need to know which one to generate.  Or,
alternatively, we could go back to having just "NOT_DECODED_YET()", and
have files that include both "packet-per.h" and "packet-ber.h" undefine
"NOT_DECODED_YET" before the second header is included; I think the only
file that included both was some piece of the "plugin API" stuff, but we
might eventually be able to get rid of the "plugin API" stuff by building
libethereal as a DLL on Windows.

The "extern" issue caused an OS X build to fail, so I checked in a fix for
that one; I also fixed the hyphen and the NOT_DECODED_YET issues.  I'll
look at the "int" vs. "guint32" issue after that.