Ethereal-dev: Re: [Ethereal-dev] Re: [PATCH] acinclude.m4, configure.in

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Fri, 14 May 2004 14:27:51 +0200
On Fri, May 14, 2004 at 01:21:27PM +0200, Thomas Anders wrote:
> Two objections:
> 1) I'd generally suggest supplying the directory to AC_PATH_PROG only,
>    rather than manipulating the global PATH variable. E.g.:
>    AC_PATH_PROG(KRB5_CONFIG, krb5-config, ,$PATH:$krb5_lib/bin)

ACK
Olivier: you are right too, of course :)

> 2) We currently only search for krb5-config if krb5_dir is unset.
>    This must be changed, too, obviously.

I've created a different version which should fix this. It's by no means
complete or anything, as we really should use the results of krb5-confg
in case it exists. But as an intermediate step, please test.

 ciao
       Joerg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
Index: acinclude.m4
===================================================================
RCS file: /usr/local/cvsroot/ethereal/acinclude.m4,v
retrieving revision 1.75
diff -p -u -r1.75 acinclude.m4
--- acinclude.m4	14 May 2004 10:33:00 -0000	1.75
+++ acinclude.m4	14 May 2004 12:25:07 -0000
@@ -874,6 +874,7 @@ AC_DEFUN([AC_ETHEREAL_KRB5_CHECK],
 	  # as the compiler and/or linker will search that other
 	  # directory before it searches the specified directory.
 	  #
+	  AC_PATH_PROG(KRB5_CONFIG, krb5-config, $krb5_dir/bin:$PATH) 
 	  ethereal_save_CFLAGS="$CFLAGS"
 	  CFLAGS="$CFLAGS -I$krb5_dir/include"
 	  ethereal_save_CPPFLAGS="$CPPFLAGS"