[Jerry Talkington <jtalkington@xxxxxxxxxxxxxxxxxxxxx>]

On Sat, May 08, 2004 at 06:13:01PM +0200, Ulf Lamping wrote:
> Jerry Talkington wrote:
> 
> >On Fri, May 07, 2004 at 10:04:13AM +0200, Biot Olivier wrote:
> > 
> >
> >>I think that portion of the code is about line 693 of packet-http.c.
> >>
> >>I'd also suggest to replace "Entity body" with "Uncompressed entity
> >>body" or "Compressed entity body", or replace "compressed" with
> >>"decoded" in the add_new_data_source calls. This way it is clearer
> >>to the end-user that the data is (un)compressed.
> >>   
> >>
> >
> > 
> >
> Hmmm, "Uncompressed entity body" seems to be very long for a tab label.

I agree, which is why the patch I submitted said only "Entity body," for
the reason described in the first paragraph below.
 
> >I had originally done that.  However, each data source requires a tab
> >with a fixed size equal to the name.  That's ok with the original
> >layout, but if you choose, say, layout #2, the size of the hex pane
> >jumps around when selecting decoded HTTP frames.
> >
> >With the new layouts, we should probably make the tabs overlap, so it's
> >possible to have any number of data sources without making panes jump
> >around.  In the meantime, how important is it that Packet Bytes frame
> >say whether the body is uncompressed or not?  Isn't the description in
> >the Packet Details pane enough?
> >
> > 
> >
> What do you mean with tabs overlap?

So that the tab title doesn't have to be entirely viewable for inactive
tabs.  E.g. the "Desgmented TCP (blah bytes)" would say "Deseg...", and
only be that wide, when it's not the active tab.

-- 
GPG public key:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x9D5B8762