On Sat, Apr 17, 2004 at 04:04:40PM +0200, metatech wrote:
> Here is the version 1.4 of the WebSphere MQ dissector.
Checked in.
Sending the updates as patches would work better if other changes are
made to the dissector (e.g., for changes to the core Ethereal APIs), and
might keep the messages containing the updates smaller.
Some compiler warnings:
../packet-mq.c: In function `dissect_mq_md':
../packet-mq.c:718: warning: unused parameter `pinfo'
../packet-mq.c: In function `dissect_mq_or':
../packet-mq.c:786: warning: unused parameter `pinfo'
../packet-mq.c:786: warning: unused parameter `bLittleEndian'
../packet-mq.c: In function `dissect_mq_rr':
../packet-mq.c:816: warning: unused parameter `pinfo'
../packet-mq.c: In function `dissect_mq_pmr':
../packet-mq.c:846: warning: unused parameter `pinfo'
Might "pinfo" be used in the future (e.g., to update the Info column),
or should those routines be changed not to take it as an argument?
"dissect_mq_or()" only puts two strings into the protocol tree, so it
doesn't need to know the byte order - should the "bLittleEndian"
argument be removed, or should it pass "bLittleEndian" to
"proto_tree_add_item()" (it has no effect when adding strings to the
protocol tree - although, in the future, that argument might be extended
to specify the character set and encoding of strings, as well as the
byte-order for numbers and characters in, for example, 2-byte Unicode
strings).