Ethereal-dev: Re: [Ethereal-dev] New tap code and patch for SIP

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Lars Roland <Lars.Roland@xxxxxxx>
Date: Fri, 26 Mar 2004 21:25:06 +0100
Hello all,

This new tap is very useful for me. I just haven't had the time to write it. Thanks to Martin.

However I attached patches for the sip, http, wap-wsp and the bootp tap. These patches remove a lot of redundant code by using the generic filter dialog for gui taps.

The generic filter dialog introduces additionally some improvements to these taps: A button to the dialog with saved display filters and red/green colouring of bad/good filter syntax.

Guy Harris wrote:
Martin Mathieson said:

This tap for SIP is heavily based on the existing http_stat.c


Checked in.


Is it bad form not to supply a corresponding tap-sip.c (for tethereal
presumably, which I seldom use) ?

I will supply one based on yours soon.



It might be nice to supply one - but, ultimately, we should have a
mechanism by which you can have a tap present a table without *any* GUI
code being written, and by which the same tap code could work in Tethereal
and Ethereal; the tap code would just construct the statistics and
register them, and code in Ethereal would take responsibility for
displaying the table and code in Tethereal would take responsibility for
printing it.


Well I did a little work on this. I already created a very small and simple api. I was able to change and compile a simple tap (the h225 message and reason counter) with identical source code for ethereal and tethereal. If someone is interested I will mail to the list what I have done so far.

Best Regards,

Lars

Attachment: diff.tar.gz
Description: GNU Zip compressed data