On Tue, Mar 23, 2004 at 08:20:50AM +0000, Pia Sahlberg wrote:
> attached is also a new packet-kerberos.c
> it adds a lot of new constants from the current draft
> and also adds decryption and dissection of kerberos blobs.
Some warnings:
../packet-kerberos.c: In function `dissect_krb5_Ticket_etype':
../packet-kerberos.c:1117: warning: unused variable `etype'
That variable should presumably be removed, as it now fetches into a
global variable. (The BER and PER APIs seem to require a lot of global
variables of that sort to pass information around - could that be
cleaned up?)
../packet-kerberos.c: In function `dissect_krb5_AP_REP_etype':
../packet-kerberos.c:1131: warning: unused variable `etype'
The same applies there.
../packet-kerberos.c: In function `store_keyvalue':
../packet-kerberos.c:1693: warning: assignment discards `const'
from pointer target type
"keyvalue" should be "static const char *" - or, if it's modified, a
copy should be made.
../packet-kerberos.c: In function
`dissect_krb5_decrypt_authenticator_data':
../packet-kerberos.c:2407: warning: unused parameter `pinfo'
../packet-kerberos.c:2407: warning: unused parameter `tree'
../packet-kerberos.c:2407: warning: unused parameter `tvb'
../packet-kerberos.c:2407: warning: unused parameter `offset'
Those should be _U_'ed if HAVE_KERBEROS isn't defined, or perhaps there
should be two separate definitions of the function, one without _U_'s if
it's defined and one with them if it's not.
../packet-kerberos.c:2444: warning: control reaches end of
non-void function
Presumably that function should do *something* if it can't decrypt the
data, e.g. put it into the protocol tree as an undissected blob - and it
still has to return something.
../packet-kerberos.c: In function `dissect_krb5_decrypt_Ticket_data':
../packet-kerberos.c:2489: warning: unused parameter `pinfo'
../packet-kerberos.c:2489: warning: unused parameter `tree'
../packet-kerberos.c:2489: warning: unused parameter `tvb'
../packet-kerberos.c:2489: warning: unused parameter `offset'
../packet-kerberos.c:2517: warning: control reaches end of
non-void function
The same applies there...
../packet-kerberos.c: In function `dissect_krb5_decrypt_AP_REP_data':
../packet-kerberos.c:2613: warning: unused parameter `pinfo'
../packet-kerberos.c:2613: warning: unused parameter `tree'
../packet-kerberos.c:2613: warning: unused parameter `tvb'
../packet-kerberos.c:2613: warning: unused parameter `offset'
../packet-kerberos.c:2647: warning: control reaches end of
non-void function
...and there.