Ethereal-dev: Re: [Ethereal-dev] Updates to packet-diameter.c and packet-diameter_defs.h

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <gharris@xxxxxxxxx>
Date: Fri, 19 Mar 2004 22:25:28 -0800
On Fri, Mar 19, 2004 at 01:49:11PM +0100, Anders Broman (AL/EAB) wrote:
> Included is a patch to packet-diameter.c to fix the use the value strings for decoding of AVP values, and
> added filter posibillities on result code and session ID.
> ..defs.h is updated with some more AVP:s resultcodes etc.

Some warnings:

	../packet-diameter-defs.h:296: warning: `SIP_user_data_request_type'
	    defined but not used
	../packet-diameter-defs.h:303: warning: `SIP_user_authorization_type'
	    defined but not used
	../packet-diameter-defs.h:311: warning: `SIP_reason_code_vals' defined
	    but not used
	../packet-diameter-defs.h:319: warning:
	    `SIP_user_data_already_available_vals' defined but not used
	../packet-diameter-defs.h:326: warning: `SIP_server_assignment_type'
	    defined but not used
	../packet-diameter.c:218: warning: `hf_diameter_avp_public_id' defined
	    but not used
	../packet-diameter.c:219: warning: `hf_diameter_avp_private_id' defined
	    but not used

and there was also an error:

	@@ -255,7 +281,177 @@
	 	{3, "Timestamp"},
	 	{0, NULL}
	 };

		...

	+/	/* Protocol errors */

		...

with the "/" at the beginning of the line.