Martin Regner wrote:
Jeff Morriss wrote:
This patch puts the ISUP CIC into the CIRCUIT_ID column instead of
displaying it in the INFO column--I think it makes more sense this way
(and is more flexible). One disadvantage, however, is that if there are
multiple ISUP messages in a single frame (e.g., when over SCTP) then you
can't see all the CICs for all the different messages in the Summary pane.
Also, I'm not sure if I did the "col_expr" stuff right (or if setting
this is even necessary or useful).
What do you think?
I would like to still have it in the Info-column.
For someone that looks a lot at ISUP captures it maybe
makes sense to use separate Circuit column, but for
someone that looks now and then it is maybe better to
have it in Info-column. Then you also have the other disadvantage
with multiple ISUP messages in the same packet.
I would prefer if the beviour is configurable (and maybe the default
should be to show it in Info-column, since by default there is no
Circuit column) from preferences, i.e. have a preference setting
whether to show the CIC value in the Info-column or not.
If you have a Circuit column you should get the value
there independently of the preference setting, I think. It is just one
of the lines in the patch I'm arguing about: the one where you
remove the information from the Info-column. I want that part to be
determined by a preference setting.
Okay, that's easy enough--the attached patch does that (the default
behavior is as it is now: the CIC is displayed in the Info column).
Please consider for inclusion.
I was actually thinking of making a patch for adding the CRV
value for Q.931 in the Info-column if a preference setting
i set (and then also make a "fence" so that the information is
not overwritten by H.225 dissector and so on).
You may have similar problem with multiple H.225/Q.931
messages in the same packet in certain scenarios.
Hmm, I have to plead (complete) ignorance of H.225. For SIGTRAN over
SCTP we should be fine because SCTP sets up the fence for everything
carried above it.
Attachment:
isup-cic-column-pref.patch.gz
Description: GNU Zip compressed data