Ethereal-dev: Re: [Ethereal-dev] patch for wiretap lib: read EyeSDN USB S0

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 13 Feb 2004 11:28:08 -0800

On Feb 13, 2004, at 6:22 AM, Rolf Fiedler wrote:


From: Guy Harris <guy@xxxxxxxxxxxx>

eyesdn.c:86: warning: `eyesdn_rec_magic' defined but not used
Yes, the magic for a record is only 0xff (single byte) and I must have put that 
in literally without referencing the array.


OK, I've gotten rid of that variable (and some unused #defines).
No, that should be an array of unsigned char. I did not notice this during testing, 
it is a leftover from the toshiba wiretap module that I started from.
Maybe I was lucky/unlucky to not have byte with most significant bit set during my tests. 
Thanks for finding this.
Should I fix it or is it already done in CVS?


It's already fixed in CVS.