Ethereal-dev: Re: [Ethereal-dev] randpkt.c patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sun, 01 Feb 2004 14:58:00 +0100
Gisle Vanem wrote:

BTW. Shouldn't simple_dialog.h be moved to ./gtk since
that's where simple_dialog.c is ?

And there seems to be some inconsistency in the way it is included. E.g. gtk\follow_dlg.c says #include "simple_dialog.h",
but gtk\fc_stat.c says  #include "../simple_dialog.h".

--gv

As far as I understand it, the file simple_dialog.h is in the rootdir,
as it defines a kind of an interface (like some other files too).

All GUI's have to implement this interface, as we might get other GUI's
such as a specific KDE or WIN32 GUI in the future.

All of these GUIs have to implement the same syntax, so the place of
this file is correct.


I'm not sure, how the #include statement in the gtk files should look
like. Of course, it should be the same in any files in the GTK dir,
not sometimes this and sometimes that way.

../simple_dialog.h forces to keep a specific file hierarchy,
simple_dialog.h forces to set the include path correct in the makefile

Don't know, what the intended way is.

Regards, ULFL