Greg Morris wrote:
Maybe I am not understanding your comments but I would be very unhappy
if I had to maintain both the GTK1 and GTK2 developer environment
because the build did both. Is this what you meant by parallel? What are
you calling the installer? Are you talking the actual NSIS install
package? If so then why not let the developer build what version he
wants and then he can deliver it to his end user. I don't really
understand why the changes were made. Under the old make files, I could
build either GTK1 or GTK2 depending on the settings in the config.nmake.
This is still true, as you can decide which version you would try to buld.
See comments for GTK1_DIR /GTK2_DIR in the config.nmake for details.
If this isn't working as expected, it's a bug, so please let me know.
Now it seems like this process has become way more complex then
necessary. I realize you are trying to make this easier and to work all
the bugs out but building in different directories isn't something that
I would want.
The simple thing here is to be able to specify in the config.nmake if
you want GTK1 or GTK2,
...thats the point! It's not about GTK1 *or * GTK2 but GTK1 *and/or*
GTK2 without regeneration all the time!
This will be also essential for building an installer for both versions
1 and 2!
The Ethereal_win32_libs will point to the
standard directory for the GTK modules necessary for that version. The
build would include the appropriate modules and the nsis packager would
do the same. Am I missing something here? Before the latest
modifications I did have to go to the packaging/nsis directory to make
the install package but that was a little step.
You shouldn't have to do this now, see the "packaging" target in the
Makefile.nmake.
I don't mean to sound like such a critique but it seems like it is
becoming even more complicated then it already was. I look forward to
your new changes. Please don't take any of my comments personal.
Greg
No problems!
The changes made was intended to be able to make things really in
parallel, not only to choose which GTK version
you want to build. Under the former makefile, you had to choose which
version you would like to build in the config.nmake.
That was ok for your special case, but when you are developing GTK
things for both versions, this was a pain in the a**.
I was trying to have an environment where you can build both versions in
parallel (meaning generating both ethereal.exe *and*
ethereal2.exe *without* changing the config.nmake all the time).
As described above, you should set GTK1_DIR / GTK2_DIR as appropriate in
the config.nmake, and you should get the result as described.
All other settings should follow this configuration.
Regards, ULFL