Ethereal-dev: Re: [Ethereal-dev] SMPP: Multiple PDU's within one TCP packet

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Chris Wilson <chris@xxxxxxxxxxxxx>
Date: Mon, 19 Jan 2004 16:23:03 +0000
On Sun, 18 Jan 2004 04:42:49 -0800
Guy Harris <guy@xxxxxxxxxxxx> wrote:

> On Sun, Jan 18, 2004 at 12:16:23PM +0000, Chris Wilson wrote:
> > Ok - I'll make things work that way.
> 
> Note that if you make it use "tcp_dissect_pdus()" you'll get that for
> free.

Yep, it's great :)

Lets have another go then, this is much nicer... Attached is a patch to packet-smpp.c (version 1.25 - that's before Olivier's last commit). It uses tcp_dissect_pdus() if it's running on TCP (it checks that pinfo->ptype==PT_TCP - which I hope is sensible!).

Olivier: Shall I also go ahead and separate the GSM SMS User Data dissector from the SMPP dissector so that it can be used by other dissectors?


Cheers,

Chris

Attachment: smpp.patch2.gz
Description: Binary data