["Olivier Biot" <ethereal@xxxxxxxxxx>]

Hello Anders,

 

The media subdissectors only need their fully-qualified media type. However it looks like we will need to add this media_type to any media subdissector as we're currently only using the pinfo->match_string for this, but we then do not have access to the essential media type parameters such as the character set for text media dissectors, and the boundary string and possible start info for multipart media encapsulation. Unless we can live with a solution based on adding this info in pinfo->private_data.

 

Regarding your 2nd item, it is already available since last week. Look at packet-text-media.c for this!

 

Regards,

 

Olivier

----- Original Message -----

From: Anders Broman

To: 'Olivier Biot'

Cc: ethereal-dev@xxxxxxxxxxxx

Sent: Sunday, January 11, 2004 11:22 AM

Subject: SV: [Ethereal-dev] New dissector for content type multipart/mixed (2)

Hi,

Sounds good, I was thinking that the sub dissectors might need the rest of the ”header data”  but was unsure  about the best way of doing it.

 

Another thing I was thinking about is if we should make a generic dissector that took care of all media types which could be output as raw text which

could be used until some one need to do something with the content and builds a separate dissector.

Best regards

Anders

 

-----Ursprungligt meddelande-----
Från: Olivier Biot [mailto:ethereal@xxxxxxxxxx]
Skickat: den 11 januari 2004 03:04
Till: Anders Broman
Kopia: ethereal-dev@xxxxxxxxxxxx
Ämne: Re: [Ethereal-dev] New dissector for content type multipart/mixed (2)

 

Hi Anders,

 

This version looks very promising. I took the liberty to add generalized support for multipart/mixed and multipart/related; adding support for another multipart type is straightforward. The version I have at hand already shows multipart/related over HTTP. I still need to tweak some stuff and then it can be added to the release!

 

In the modifications, I have inserted a pointer to the headers_t structure into the pinfo->private_data, where I also added the content-type parameters. I envisage to add a "media_types.h" file (in NOINST_headers) with common code for media dissection. Please comment on this.

 

Regards,

 

Olivier

----- Original Message -----

From: Anders Broman

To: ethereal-dev@xxxxxxxxxxxx

Sent: Saturday, January 10, 2004 10:47 PM

Subject: [Ethereal-dev] New dissector for content type multipart/mixed (2)

 

Hi,

I’ve removed the checking of compact type headers as I think they will not be used in multipart/mixed,

Changed to use tvb_length_remaining in the loops instead and changed the check for unquoted boundary string in the

Content type string.

Best regards

Anders