Ethereal-dev: Re: [Ethereal-dev] Edit color filter - delete and cancel

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Richard Urwin <richard@xxxxxxxxxxxxxxx>
Date: Sat, 10 Jan 2004 12:18:45 +0000
On Saturday 10 Jan 2004 12:20 am, Guy Harris wrote:
> On Jan 9, 2004, at 3:03 AM, Richard Urwin wrote:
> > This arises because the color filter dialog works on the actual color
> > filter
> > data.
> > The GTK2 code has a copy of that data in the list box. However the
> > GTK1 code
> > does not. We could make a copy of the data, but then the GTK2 list box
> > data
> > would be redundant.
>
> I don't think we have megabytes of color filter data, so I'm not sure
> the redundant copy is a real problem.
>
> Perhaps the dialog should:
>
> 	save the existing set of color filters as a "revert to" set;
>
> 	act on some private copy of the data when you add/delete/change/move
> color filter items;
>
> 	set the active color filter list to match the display, and re-colorize
> if it's been changed, when you click "Apply" or "OK";
>
> 	set the active color list to the saved list, and re-colorize it if the
> active list has been changed by "Apply", when you click "Cancel".

Yes, I think it should. I suppose I could do that if nobody else wants to.

-- 
Richard Urwin