Ethereal-dev: Re: [Ethereal-dev] Fixing the "no coloring after unmarking" bug

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Fri, 9 Jan 2004 04:00:03 +0100
From: "Guy Harris"

> On Jan 8, 2004, at 3:47 PM, Olivier Biot wrote:
>
> > I'm trying to fix the very old and well-known "no coloring after
> > unmarking"
> > bug. A quick look at main.c yields the starting point: set_frame_mark()
> > which uses NULL color_t structs when we unmark a frame. Is it
> > acceptable to
> > store the color filter colors in the frame_data structure when we
> > apply the
> > color filters?
>
> I guess, although it does increase the memory requirements per frame.
>
> I'd store just a pointer to the color filter that applied to the frame;
> that'd save some memory.

That's the way I implemented it. I don't consider the overhead of one
pointer per packet too heavy; besides, I'd like to reuse this color in the
printing subsystem. I just checked it in :)

Regards,

Olivier