[Guy Harris <guy@xxxxxxxxxxxx>]

On Jan 7, 2004, at 9:28 AM, Jean Tourrilhes wrote:

> 	As far as I can see, the IrDA protocol really uses 0x2F as the
> XID command. This is easy to verify, as XID is used for basic
> discovery. The log below is my Palm-Pilot discovering my Linux box :

I.e., that's your Palm Pilot sending the XID command?

Sigh.  I don't know whether that was just somebody putting a "0" where 
there should have been a "1" in the table of UI command values, or a 
deliberate choice on the part of the people developing the IrDA spec, 
but it looks as if "dissect_xdlc_control()" would have to be changed in 
order to handle IrDA's non-HDLC code for XID commands.

Probably the right thing to do is to have it take a "const value_string 
*" argument that points to a value_string table for mapping UI commands 
to short names; if it's null, the HDLC table is used, otherwise that 
table is used.  (The long names are used in fields, and the fields are 
supplied by the dissector calling "dissect_xdlc_control()", so that's 
not an issue.)

I'll look at doing that.