Ethereal-dev: RE: [Ethereal-dev] RFC: Put cvs date into version

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Anders Broman (TN/EAB)" <anders.broman@xxxxxxxxxxxx>
Date: Wed, 7 Jan 2004 16:07:36 +0100
Hi,
I normaly build from the "tarball" would that also include the version+date ?
Best regards
Anders

-----Original Message-----
From: ethereal-dev-bounces@xxxxxxxxxxxx
[mailto:ethereal-dev-bounces@xxxxxxxxxxxx]On Behalf Of Biot Olivier
Sent: den 7 januari 2004 14:29
To: 'Joerg Mayer'
Cc: ethereal-dev@xxxxxxxxxxxx
Subject: RE: [Ethereal-dev] RFC: Put cvs date into version


| -----Original Message-----
| From: Joerg Mayer
| 
| OK, take 2

Hi Joerg,

I very much like your proposal, so I gave it a try!
I verified the code, and there are some concerns:

1. You need to run the perl script with "$PERL filename.pl"
   This also requires that the check for perl must happen
   prior to running "$PERL filename.pl".
2. I like to know which was the last released version from
   which the cvs version is derived.
3. Most of the time I do a "cvs -z 3 update -P -d" followed
   with a mere "make". The version as computed by ./configure
   and stored in config.h will be stale.
4. You cannot build an official release from CVS as there will
   always be a CVS directory.

If we assume that whenever a new version is released, the
configure script is updated, then we can keep the base version
in the configure script as is.

In order to compute a valid "CVS version" identifier, we need
to define it in the Makefiles so every run of make computes an
up-to-date version identifier. So that would be the place to
run the cvsdate.pl script. As a result, $PERL is already
defined for us by ./configure, so the order of the autoconf
macros is no longer an issue :)

Maybe we can use a "-DCVS_VERSION=xxxxxx" compiler flag in
the Makefiles for the CVS version as it is conditionally
defined (only if using CVS)?

This still leaves issue 4 open.

Anyway, I'd like to have some comments on this from the other
people on the list :)

Regards,

Olivier

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev