Ethereal-dev: Re: [Ethereal-dev] Need a fix in packet-fw1.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 6 Jan 2004 13:13:20 -0800

On Jan 5, 2004, at 11:34 PM, Biot Olivier wrote:
A recent posting on ethereal-users reported a crash which apparently occurs when the Ethernet preference "Interpret as FireWall-1 monitor file" is set 
by accident.
As I am not acquainted with FW1 (I don't have the specs at hand either) I'll 
just post a capture which causes a crash (just enable the Ethernet
preference for it to occur).
The specs aren't necessary - it was a very simple bug; it maintains a list of interface names, with a fixed size, but if it finds an interface not in the list, it adds a new entry to the list *even if the list is full*, so an array was overflowing. 

I've checked in a fix.