On Sun, Jan 04, 2004 at 04:56:12PM -0800, Richard Sharpe wrote:
> if you bring up the Diabled Protocols dialog box, toggle the status of a
> protocol, and then click Save, Ethereal will then rescan the capture file.
> This seems reasonable.
>
> If you then click on the X button on the decoration to destroy the window,
> Ethereal will do another rescan.
Currently, requesting that the window be deleted (e.g., clicking on the
"X" button on Windows and in many X window managers) the window is
equivalent to clicking "Cancel".
The GNOME HIG's section on preferences windows:
http://developer.gnome.org/projects/gup/hig/1.0/windows.html#preference-windows
speaks only of a "Close" button. If preferences were saved as soon as
they were changed, that makes sense.
Unfortunately, if preferences were saved as soon as they were changed,
that would make it inconvenient to change settings for the current
capture - you'd be changing them for all subsequent captures, even in
subsequent invocations of Ethereal, and would have to change them back
if you only wanted them for that capture.
However, the section of the HIG on "instant apply":
http://developer.gnome.org/projects/gup/hig/1.0/windows.html#instant-apply
says:
For windows that allow the user to change values or settings,
such as property and preference windows, update those values or
settings immediately to reflect the changes made in the window.
This is known as "instant apply". Do not make the user press an
OK or Apply button to make the changes happen, unless either:
o the change will take more than about one second to apply,
in which case applying the change immediately could make
the system feel slow or unresponsive, or
o the changes in the window have to be applied
simultaneously to prevent the system entering a potentially
unstable state. For example, the hostname and proxy fields
in a network properties window.
If either these conditions affect only a few of the controls in
your window, arrange those controls together into one or more
groups, each with its own Apply button. Leave the rest of the
controls as instant apply.
The "Disabled Protocols" list, *and* the protocol preferences, may well
take more than one second to apply, especially with large captures, so
they probably should *not* be "instant apply" settings.
"Explicit apply" windows have "Apply", "Cancel", and "OK" buttons.
I don't see anything obvious on that HIG page to indicate whether
closing an "Explicit apply" window should act as "Cancel" or "OK".
Perhaps it's supposed to act the same way the default button does?