Ethereal-dev: Re: [Ethereal-dev] Saving all packets between the first and the l ast marked pac

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Dick Gooris <gooris@xxxxxxxxxx>
Date: Tue, 23 Dec 2003 04:07:34 -0800
Biot, Guy,

Adding all the proposals :

+-- Select packets to be %s ------------------+
| (*) all packets  {N packets}                |
| ( ) selected packet {1 packet}              |
| ( ) marked packets {N packets}              |
| ( ) range from first to last marked packet  |
+ - - - - - - - - - - - - - - - - - - - - - - +
| [x] apply display filter on the above       |
+---------------------------------------------+


Taken that the 'selected packet' is always only one packet. Please confirm.

If there is only one marked packet, we will save just one packet in case we choose the range from first to last marked packet.

Regards,

   - Dick Gooris

Biot Olivier wrote:

Some remarks:

Can we select more than one packet in the GUI? IMHO we can only do this by
having pop-up windows with individual packets being displayed.

Range between first and last marked packet is only possible when at least 2
packets have been marked.

Maybe we can group functionality based on applying the dfilter or not:

+-- Select packets to be %s ------------------+
| (*) all packets                             |
| ( ) selected packets                        |
| ( ) marked packets                          |
| ( ) range from first to last marked packet  |
+ - - - - - - - - - - - - - - - - - - - - - - +
| [x] apply display filter on packet range    |
+---------------------------------------------+

where %s is either printed or saved, (*) is the default selected radio
button of the radio button group, and [x] represents a selected check box.

Regards,

Olivier

PS in Dutch-speaking Belgium, it is customary to write last name first (as
does our corporate Exchange server). People call me Olivier :)

| -----Original Message-----
| From: Guy Harris
| | On Tue, Dec 23, 2003 at 02:37:30AM -0800, Dick Gooris wrote:
| > Guy, Biot, Ulf,
| > | > Would it be an idea to make a set of radio buttons instead | of a check | > button. | | That's what the "Print" dialog box has. I think that the "Print" and
| "Save" dialog boxes should have the same options for selecting which
| packets to {print,save}.
| | > I think of the following design then (for Save As.. ) : | > | > O Save all packets
| > O  Save only packets currently being displayed
| > O  Save only marked packets
| > O  Save packet range between first and last marked packets.
| > O Save currently displayed packet range between first and | last marked | > packets. | | Or | | +-Save | Range-------------------------------------------------------------+ | | | | | | O Selected packets only, {N} packets | | | | O Marked packets only, {N} packets | | | | O All packets captured, {N} packets | | | | O All packets displayed, {N} packets | | | | O Displayed packets between first and last marked | packet, {N} packets | | | O Captured packets between first and last marked packet, | {N} packets | | | | | | | +-------------------------------------------------------------
| -----------+
| | along the lines of what we have in the Print dialog box. | | Should we have another one for "Marked displayed packets"? | | > Proposed UI rules : | > | > - All the above are radio buttons | | ...as is the case currently in the Print dialog. | | > - The default is the first one: 'Save all packets' | | ...as is *not* currently the case in the Print dialog, but as arguably
| *should* be the case in the Print dialog.
| | > - "Save only marked packets", "Save packet range between | first and last | > marked packets", and "Save displayed packet range between | first and last | > marked packets", will become not selectable in case no | markers are set. | | Yes. | | > - "Save only packets currently being displayed", and "Save | displayed | > packet range between first and last marked packets" become | unselectable | > when there is no display filter set. | | Yes (that's already the case for "All packets displayed" in the Print
| dialog box).
| | "Selected packets only" is unselectable if there is no | selected packet. | | The rule is that if {N} is 0 for any item, the item is not selectable. | | > We can add a radio button later which says ' O Save packet list [ | > Entry for packet list ] ' based on unfiltered packets, and | again a list | > of displayed packets. The last becomes rather complex due | to the holes | > in the numbering of the packets showed. | | I assume that's for user-specified packet ranges? | | Ulf, what did you have in mind for the range?