On Sun, Dec 21, 2003 at 07:09:45AM +0100, Joerg Mayer wrote:
> Here are some warnings that I see when compiling Ethereal:
>
> packet-diameter.c:1630: warning: ISO C90 does not support the `%z'
> strftime format
It's not even guaranteed that a "struct tm" contains a time zone offset.
We should probably just get rid of the "%z" entirely.
> packet-rsvp.c:2577: warning: ISO C90 does not support the `ll' printf
> length modifier
...and neither do the "printf"-family routines (and our printf-like
routines use that code) on older BSDs and Windows.
We'd need to have autoconf determine the right format on UNIX, and have
a #define in config.h.win32 on Windows, and use that rather than wiring
in "%ll[dox]".
> packet-gsm_map.c:317: warning: `Dgt_tbcd' defined but not used
I think the intent is to use that in the future, as more dissection is
done.
> packet-acn.c:660: warning: unused parameter `tvb'
> packet-acn.c:660: warning: unused parameter `offset'
> packet-acn.c:660: warning: unused parameter `tree'
> packet-acn.c:660: warning: unused parameter `parent_hist'
> packet-acn.c:660: warning: unused parameter `max_size'
I presume the intent is to fill in the "dissect_dmp()" routine.
> packet-v5ua.c:1654: warning: unused parameter `tree'
Presumably there's *something* it should be putting into the protocol
tree....
> plugins.c:230: warning: dereferencing type-punned pointer will break strict-aliasing rules
> plugins.c:245: warning: dereferencing type-punned pointer will break strict-aliasing rules
> plugins.c:250: warning: dereferencing type-punned pointer will break strict-aliasing rules
I think those might be impossible to fix - I think there's no way to
avoid the type punning.
> packet-mtp3.c:648: warning: dereferencing type-punned pointer will break strict-aliasing rules
"mtp3_net_addr_fmt" should be made a "gint" rather than an enum.
> packet-tcap.c:2754: warning: dereferencing type-punned pointer will break strict-aliasing rules
I think that's a similar issue.