Ethereal-dev: Re: [Ethereal-dev] Crash in SMPP

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Fri, 19 Dec 2003 15:50:59 -0800

On Dec 19, 2003, at 3:15 PM, Biot Olivier wrote:


Should the README.developer be updated so the "common code" from tvb =
process_reassembled_data() is used instead of the tvb = tvb_new_real_data() 
and other calls?


Yes.


| However, that means it treats the packet as reassembled and
| hands it to the WSP dissector.

I have noticed this; I'd need to prevent this. Does the "common code"
provide a means of doing this?
No. By the time "process_reassembled_data()" has been called, the damage has already been done. 

That's why I said


| We should arrange that the aforementioned hack is
| done *ONLY* for 802.11; I'll look at doing that.
I.e., the reassembly code needs to be fixed so that the 802.11 code can say "do reassembly with this hack", and reassembly for other protocols using "fragment_add_seq_check()" doesn't do that hack.