Hi,
I have no knowledge about the http protocol so I can't say anything about the similarities,
but in general it should be advantageous to make common code/routines for all types of text based
protocolls ( HTTP,SIP,MEGACO,MGCP,RTSP..comes to mind )as it looks to be the same type of problem to parse them.
And the solutions looks different in each dissector.
Brg
Anders
-----Original Message-----
From: Guy Harris [mailto:guy@xxxxxxxxxxxx]
Sent: den 17 december 2003 21:42
To: Anders Broman (TN/EAB)
Cc: 'Biot Olivier'; ethereal-dev@xxxxxxxxxxxx; 'Arsen Chaloyan'
Subject: Re: [Ethereal-dev] Cann't open capture file (SIP, RTP) (patch)
On Dec 17, 2003, at 3:22 AM, Anders Broman (TN/EAB) wrote:
> The problem is that there is an extra octet at the end of packet 195,
> and no protection in packet-sip.
Packet 195? That's an RTP packet.
> This is fixed with the included patch.
> It also includes some (unfinished) code to include "parameters" to
> Content-type.
It also removes some code that does something with a media type of
multipart/mixed - but it didn't do anything useful, it just set some
variables that weren't being used. The right way to handle
multipart/mixed is (as I think was mentioned in some other messages) to
have a subdissector for it, and pass it the boundary string.
Checked in, with indentation fixes.
Should the SIP and HTTP dissector share code to parse headers? We
should perhaps make common code to handle the headers, with whatever
features are needed for both protocols.