Ethereal-dev: Re: [Ethereal-dev] Computing key id in DNS KEY RR

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: David Fort <david.fort@xxxxxxxx>
Date: Thu, 11 Dec 2003 11:05:23 +0100
Guy Harris wrote:


On Dec 10, 2003, at 10:11 AM, David Fort wrote:

With this little patch you can see the id of a key in a DNS KEY RR. This
is against the last ethereal snapshot.


Checked in, with changes to:

1) eliminate the check for tvb not being null in "compute_key_id()" - if it were null, Ethereal would have failed long before it's called;

2) have "compute_key_id()" return an "int", and return -1 if the size is bad or the algorithm is unknown, rather than printing a message;

3) have its caller not put the key ID into the protocol tree if "compute_key_id()" returns -1.


i got nothing against all that.

--
Projet IDsA
IRISA-INRIA, Campus de Beaulieu, 35042 Rennes cedex, France
T�l: +33 (0) 2 99 84 71 00, Fax: +33 (0) 2 99 84 71 71