I checked in a fix some minutes ago. I also got rid of the unused
wbxml_handle in packet-wsp.c. Compiled and executed with a 9 MB historical
collection of snoops :)
Regards,
Olivier
| -----Original Message-----
| From: Biot Olivier
|
| | From: Guy Harris
| |
| | On Sun, Dec 07, 2003 at 01:22:01PM +0100, Biot Olivier wrote:
| | > Agreed. However, there are TWO media dissector tables in WSP:
| | > - the literally represented media type table (e.g., "text/html")
| | > - the numerically represented media type table (e.g., 0x01)
| | >
| | > We cannot get rid of the "numerical table", as some media
| | types are only
| | > registered in this table.
| |
| | Is that because there are some numerically-represented media
| | types that
| | have no corresponding text-represented media types?
|
| I have to reconsider this... My concern was based on the fact
| that there is
| WBXML-encoded content for which the Content-Type header is
| set e.g., to
| application/vnd.wap.wmlc (0x14 in decimal WAP
| representation), but the WBXML
| public ID is either 0x02, 0x04, 0x09, 0x0A, 0x1108, 0x110D
| etc depending on
| the WML version (or proprietary WML scheme). This however is
| handled in the
| WBXML dissector, so it is indeed safe to get rid of the
| integer media type
| dissector table.
|
| | If not, perhaps those media types should be registered under
| | their text name as well;
|
| This is already done, but not in the WSP dissector. It is
| only done in the
| dissectors running on top of WSP (currently only MMSE and WBXML).
|
| | if that's done, would it make sense to have the WSP
| | dissector map the numerical media type to a text media type, and do
| | handoffs by looking up that media type in the "media_type" dissector
| | table?
|
| Definitely :) The handoff will only have a dissector_try_string()
| and a dissector_try_heuristic() call. I will provide a fix this
| evening, which will also update the add_content_type() call so we
| always get a text string media type.