I just checked in this change.
Regards,
Olivier
| Please ignore previous patch (my outdated tree didn't have
| the "media_type" dissector table). Fixed in attached patch.
|
| Regards and sorry,
|
| Olivier
|
| | -----Original Message-----
| | From: Biot Olivier
| |
| | | From: Guy Harris
| | | Subject: [Ethereal-dev] Are WSP content types the same as
| | | HTTP content types?
| |
| | Yes, they are. WSP is a "over-the-air optimization" for HTTP/1.1.
| |
| | | If so, the WSP dissector could just get the Internet media type
| | | dissector table (which used to be the HTTP content type
| | | dissector table)
| | | by calling
| | |
| | | find_dissector_table("media_type")
| | |
| | | in its reg_handoff routine, and use that rather than
| | creating its own
| | | "wsp.content_type.literal" dissector table.
| |
| | Agreed. However, there are TWO media dissector tables in WSP:
| | - the literally represented media type table (e.g., "text/html")
| | - the numerically represented media type table (e.g., 0x01)
| |
| | We cannot get rid of the "numerical table", as some media
| | types are only
| | registered in this table.
| |
| | The patch to packet-mmse.c and packet-wbxml.c is trivial (rename the
| | dissector table). For the WSP dissector, we also need to
| | refer to the HTTP
| | content type dissector table "http.content_type". Attached
| | patch does this.
| |
| | I tested it by comparing the output of tethereal -V on a
| | capture containing
| | HTTP, WSP and MMSE before and after applying the patch.
| |
| | Please review and check in.
| |
| | Regards,
| |
| | Olivier
|