Ethereal-dev: Re: [Ethereal-dev] gtkclist.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 2 Dec 2003 23:28:07 -0800
On Wed, Dec 03, 2003 at 02:20:04AM -0500, Ian Schorr wrote:
> This is probably a stupid question, but I just noticed that we only use 
> the gtk/gtkclist.c with GTK+1.2, not with 2.x or with 1.3 (Win32) (which 
> was probably why it was renamed gtkclist_v12.c)...  Why do we have a 
> "custom" version of this file for 1.2 only?  That is, what was being 
> worked around/enhancing in 1.2 that we don't need to do for 1.3 (Win) or 
> 2.x?

A lack of performance in older versions of 1.2 - appending rows to a
GtkClist was done by starting at the first row and scanning forward to
find the last row, rather than by remembering the last row and appending
after that.  Current versions of GTK+ 1.2[.x] don't have that problem,
and neither do 1.3 nor 2.x.

We could probably get rid of our own private version at this point.