Ethereal-dev: Re: [Ethereal-dev] [PATCH][WSP]Decoding of Quoted-string

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Loïc Minier <lool+ethereal@xxxxxxxxxx>
Date: Tue, 18 Nov 2003 14:03:01 +0100
Biot Olivier <Olivier.Biot@xxxxxxxxxxx> - Tue, Nov 18, 2003:

> Regarding the Quoted-string issue, I have already seen the following:
> 	1. "text
> 	2. "text"
> 	3. text (on rare occasions; should be flagged as an error anyway)

 Yes, case 3 is clearly an error and case 2 might no be one, as in:
   ""Lo�c Minier"

 So I don't think that removing the trailing quote is a good idea. Is my
 patch for removing the leading quote ok?

> I like your proposal for is_quoted_string(x) but I also want the
> get_quoted_string() macro to be correct :)
> I would suggest to fall-back to get_text_string() in the code wherever
> get_quoted_string() fails (ok == FALSE), and to document this. In case we
> fall back, I want to display a warning too, like I already do in similar
> cases. And the logic of this fall-back must be explained in the code too so
> other developers know why it's in etc etc...

 Seems intelligent to me.

-- 
Lo�c Minier <lool@xxxxxxxx>