On Nov 11, 2003, at 9:03 PM, Chris Waters wrote:
I've attached a patch for the TZSP dissector. Here are the changes:
* Better decoding of TZSP header.
* Handle unknown tags in packet.
* Removed encapsulation types which are not actually supported.
* Added tags for original length and sensor address.
and
* Fix signedness of some fields.
Checked in, with some changes (get rid of unused "hf_tzsp_reserved"
variable, use -1 rather than "tvb_length(tvb)" when constructing the
top-level protocol tree item and set the length of that item not to
include packet payload if present, have "add_option_info()" take a
starting offset rather than constructing a subset tvbuff for it, use
"proto_tree_add_item()" in some cases, use "proto_tree_add_int()"
rather than "proto_tree_add_int_format()" in cases where the former
should be sufficient).
Is it the case that "Received tag list", "Reserved", and
"Configuration" packets can contain an encapsulated packet? If not, or
if some but not all can contain one, perhaps the subdissector should
only be called for packets that would contain an encapsulated packet.