I.e. the code in ethereal wont be changed unless it can be shown that a real
MS implementation does it differently from
ethereal.
----- Original Message -----
From: "Ronnie Sahlberg"
Sent: Sunday, November 09, 2003 8:08 AM
Subject: Re: [Ethereal-dev] patch for packet-smb.c (Locking_AndX)
> I am not sure this fix is correct.
>
>
http://www.ethereal.com/cgi-bin/viewcvs.cgi/ethereal/packet-smb.c.diff?r1=1.365&r2=1.366
> The reason it was changed FROM what you suggest TO what it is corrently
> was based on what real Microsoft Clients/Servers report in the call.
>
>
> ----- Original Message -----
> From: "Luis Claudio R. Goncalves"
> Sent: Saturday, November 08, 2003 7:02 AM
> Subject: [Ethereal-dev] patch for packet-smb.c (Locking_AndX)
>
>
> > Hi!
> >
> > I've been playing around with locks in samba and I've seen that the
offset
> > and length reported by ethereal for large file locks are not the same
I've
> > requested and thus not the same reported by samba logs.
> >
> > The locking offset and length are 64bit integers sent as OffsetHigh
> (32bit)
> > and OffsetLow (32bit). The glitch seems to be only the mix between high
> and
> > low 32bit words.
> >
> > The patch attached just does a little change in
> > dissect_locking_andx_request(), file packet-smb.c
> >
> > I tried it with ethereal-0.9.10 and I've seen that this code still be
the
> > same in 0.9.16.
> >
> > Regards,
> > Luis
> >
> > PS: I'm not subscribed to this mailing list... :)
> > --
>
> _______________________________________________
> Ethereal-dev mailing list
> Ethereal-dev@xxxxxxxxxxxx
> http://www.ethereal.com/mailman/listinfo/ethereal-dev