Ethereal-dev: Re: [Ethereal-dev] new dissectors + corrected FC reassembly code

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 29 Oct 2003 18:58:44 -0800

On Oct 29, 2003, at 6:50 PM, Dinesh G Dutt wrote:

BTW, "tvb_set_reported_length()" throws an exception if you try to make
I did this because I thought that you suggested this would be the thing to do to allow the errors to be reported as "short frame" instead of "malformed
frame".

Setting the reported length is the right thing to do. However, using "tvb_set_reported_length()" isn't the right way to do it - unfortunately, there isn't a right way.

(Perhaps if I can get around to reworking the whole "packet length" stuff I can handle that better - there are cases where you arguably *should* be able to set *some* length longer, e.g. if you have an IP packet with a bogus length value > the actual length of the link-layer payload.)

I don't have the hardware to test this patch. This seems iffy and so I'd rather
we remove this patch and introduce it in a subsequent release.

OK, I'll remove that particular part of the change - should I leave in the rest of the stuff that dissects the length and the truncated bit?