Ethereal-dev: Re: [Ethereal-dev] New release rush - small patch for packet-dcerpc.c, big patch

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 27 Oct 2003 13:59:03 -0800

On Oct 27, 2003, at 5:02 AM, Yaniv Kaul wrote:


I apologize for the (usual) mess I'm doing while submitting patches.
Attached please find a patch of packet-dcerpc-oxid.c against the Oct30 CVS - I hope it makes more sense. 
I believe you can remove packet-dcerpc-dcom.h - it's not needed.
So is the intent that everything that needs stuff from "packet-dcerpc-dcom.c" #include it? 

If so, then:
1) you get multiple versions of the same function if more than one source file includes it - is that intended? (I suppose you get some locality of reference for code that way....)
2) perhaps it should be ".inc" rather than ".c", as it's not a top-level source file.