Ethereal-dev: Re: [Ethereal-dev] bug in packet-teredo.c?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 21 Oct 2003 19:18:26 -0700

On Oct 21, 2003, at 5:26 AM, smhuang@xxxxxxxxxxxxxxxxxxxx wrote:
line 189, replace (teredoh-th_orgport)^(0xFFFF) with ntohs(teredoh-th_orgport)^(0xFFFF)
teredoh->th_orgport is fetched with a "tvb_get_ntohs()" call, so it's already in host byte order...
line 193, replace (teredoh-th_iporgaddr)^(0xFFFFFFFF) with ntohl(teredoh-th_iporgaddr)^(0xFFFFFFFF)
...and IPv4 addresses in Ethereal are stored in network byte order, i.e., should be fetched with "tvb_memcpy()", which is what we do, so it's already in the right byte order. 

Or am I missing something?