Ethereal-dev: Re: [Ethereal-dev] ACN plugin

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 13 Oct 2003 18:20:11 -0700

On Oct 11, 2003, at 4:56 PM, Erwin Rol wrote:

Another small problem i had/have is that i have no implementation to
verify the correctness of the plugin, so it likely still has errors.

...and some compiler warnings:

packet-acn.c: In function `dissect_sdt':
packet-acn.c:167: warning: unused variable `flags_tree'
packet-acn.c:167: warning: unused variable `flags_item'
packet-acn.c: In function `dissect_dmp':
packet-acn.c:300: warning: unused parameter `tvb'
packet-acn.c:300: warning: unused parameter `offset'
packet-acn.c:300: warning: unused parameter `tree'
packet-acn.c:300: warning: unused parameter `parent_hist'
packet-acn.c:300: warning: unused parameter `max_size'
packet-acn.c: In function `dissect_pdu':
packet-acn.c:306: warning: unused parameter `max_size'

Still i hope it can be added to CVS, so others might also work on it.

I've checked the appropriate patches and files in (not the Makefile and Makefile.in files for the plugin, as they're generated from the Makefile.am file), plus patches to the stuff in packaging/nsis.