Ethereal-dev: Re: [Ethereal-dev] lot's of warnings: redefinition of symbol 'OPT IONAL'

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 9 Oct 2003 11:57:18 -0700

On Oct 9, 2003, at 1:33 AM, Biot Olivier wrote:

This is also true for other #defined constants in other protocol where we assume that they are not defined elsewhere. Sometimes dangerous assumptions
are made, like redefining DELETE when building on Windows...
Shouldn't we add something like

	Prefer using PDU_DELETE (or PROTO_PDU_DELETE) rather than DELETE.

in the Readme.developer file?

I'm adding an item to the Portability section:

	For #define names and enum member names, prefix the names with a tag so
as to avoid collisions with other names - this might be more of an issue
	on Windows, as it appears to #define names such as DELETE and
	OPTIONAL.