Ethereal-dev: Re: [Ethereal-dev] [patch] packet-tcp.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 2 Oct 2003 15:49:31 -0700

On Sep 30, 2003, at 3:37 PM, Matthijs Melchior wrote:

Hi,
   recently I have noticed a problem with re-assembly of some of my
testing data streams.  Investigating I have found they were all created
with the text2pcap command.  And the problem was only there when I had
selected "tcp/use relative sequence numbers".  The root-cause of the
problem appeared to be the fact that a valid sequence number (0) is
used to indicate the base sequence number is not initialized. And
text2pcap actually uses that same sequence number.

The attached patch uses a different criterion to initialize the
base sequence number, it uses the fact that the "unacked list" starts
out empty. My pseudo-caputes are handled correctly now, but they
only contain data flow in one direction, and no packets in the other
direction.....

Please apply if you agree this is a better criterion to initialize
the base sequence number.

Ronnie?  Does this make sense?