Ethereal-dev: Re: [Ethereal-dev] Patch for rtp_analysis

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 25 Sep 2003 12:39:35 -0700

On Sep 25, 2003, at 12:26 AM, Lars Ruoff wrote:

Patch for the rtp-analysis code:

Checked in, with some changes (payload type 19 added to "rtp_pt.h", and "gtk/rtp_analysis.c" changed to get RTP payload types from that header; "%d"s used to print unsigned values changed to "%u"s; (statinfo->flags & STAT_FLAG_xxx == 0) changed to !(statinfo->flags & STAT_FLAG_xxx), as GCC suggested additional parentheses for the former, i.e. ((statinfo->flags & STAT_FLAG_xxx) == 0) - relational operators such as == have *higher* precedence than bitwise operators such as & - and to make it a bit clearer that we're testing for the bit not being set).