Ethereal-dev: RE: [Ethereal-dev] [christmasboy_81@xxxxxxxx: Bug#199779: Subject : ethereal: se

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Giles Scott" <gscott2@xxxxxxxxxxxxxxxxxx>
Date: Tue, 23 Sep 2003 15:41:15 +0100
Title: RE: [Ethereal-dev] [christmasboy_81@xxxxxxxx: Bug#199779: Subject : ethereal: segfault when adding filter _expression_]

your right with GTK2 relation 'is present' is not automatically selected.

it should be as line 1190 of dfilter_expr_dlg.c sets the tree to GTK_SELECTON_BROWSE
but the code is very different compared to GTK v1.

Giles


-----Original Message-----
From: Guy Harris [mailto:guy@xxxxxxxxxxxx]
Sent: Tuesday, September 23, 2003 5:00 AM
To: Scott, Giles [HAL02:466K:EXCH]
Cc: Frederic Peters; 199779-forwarded@xxxxxxxxxxxxxxx;
ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] [christmasboy_81@xxxxxxxx: Bug#199779:
Subject : ethereal: segfault when adding filter _expression_]



On Sep 22, 2003, at 1:27 AM, Giles Scott wrote:

> GS>Attached is a new patch, which sets 'can_compare' to true, if
> 'item_str' is null.
> If I just click on HTTP but not on a relation, HTTP is added as a
> filter which is the same as relation == present

But if you click on HTTP, isn't "is present" automatically selected, so
that it's *impossible* not to have a relation selected?

If not, I'd consider that a bug - if you select a field/protocol, there
has to be *some* operator testing it, so there should be a default
selected when you select the field/protocol.  The GTK+ 1.2[.x] version
works that way - it selects "is present" by default; is this some
difference between 1.2[.x] and 2.x, or is this a bug in 2.x?