["Giles Scott" <gscott2@xxxxxxxxxxxxxxxxxx>]

Title: RE: [Ethereal-dev] [christmasboy_81@xxxxxxxx: Bug#199779: Subject: ethereal: segfault when adding filter _expression_]

reproduced the issue 0.9.15 GTK+ 2.2.4, WinXP.

item_str is NULL if no relation is specified, so the strcmp is failing.

Attached is a patch. and a gdb backtrace of the issue before the fix.

Cheers

Giles

-----Original Message-----
From: Guy Harris [mailto:guy@xxxxxxxxxxxx]
Sent: Thursday, July 10, 2003 10:30 PM
To: Frederic Peters
Cc: ethereal-dev@xxxxxxxxxxxx; 199779-forwarded@xxxxxxxxxxxxxxx
Subject: Re: [Ethereal-dev] [christmasboy_81@xxxxxxxx: Bug#199779:
Subject: ethereal: segfault when adding filter _expression_]

On Thursday, July 10, 2003, at 1:59 AM, Frederic Peters wrote:

> Ethereal segfaults when adding a filter _expression_. To reproduce:
>
> click on the filter button in the lower left corner of the screen
> click add _expression_
> choose any _expression_
> click ok and ethereal segfaults

Can't reproduce on Mac OS X, built with GTK+ 1.2.10, at least; perhaps
this is problem with the GTK+ 2.x support.

_______________________________________________
Ethereal-dev mailing list
Ethereal-dev@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-dev

 

GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-cygwin"...(no debugging symbols found)...
(gdb) run
Starting program: /cygdrive/c/progra~1/ethereal/ethereal.exe 
---Type <return> to continue, or q <return> to quit--- 
---Type <return> to continue, or q <return> to quit---

Program received signal SIGSEGV, Segmentation fault.
0x77c436d0 in strcmp () from /cygdrive/c/WINDOWS/system32/msvcrt.dll
(gdb) backtrace
#0  0x77c436d0 in strcmp () from /cygdrive/c/WINDOWS/system32/msvcrt.dll
#1  0x006bc357 in libpangowin32_1_0_0_dll_iname ()
#2  0x62758f29 in g_cclosure_marshal_VOID__VOID () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#3  0x62744102 in g_closure_invoke () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#4  0x62758b64 in signal_emit_unlocked_R () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#5  0x62757d4a in g_signal_emit_valist () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#6  0x62757fa6 in g_signal_emit () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#7  0x00c211b8 in gtk_button_clicked () from /cygdrive/c/progra~1/ethereal/libgtk-win32-2.0-0.dll
#8  0x00c2259a in gtk_real_button_released () from /cygdrive/c/progra~1/ethereal/libgtk-win32-2.0-0.dll
#9  0x62758f29 in g_cclosure_marshal_VOID__VOID () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#10 0x62744949 in g_type_class_meta_marshal () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#11 0x62744102 in g_closure_invoke () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#12 0x62758522 in signal_emit_unlocked_R () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#13 0x62757d4a in g_signal_emit_valist () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#14 0x62757fa6 in g_signal_emit () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#15 0x00c21108 in gtk_button_released () from /cygdrive/c/progra~1/ethereal/libgtk-win32-2.0-0.dll
#16 0x00c223d4 in gtk_button_button_release () from /cygdrive/c/progra~1/ethereal/libgtk-win32-2.0-0.dll
#17 0x00cff01a in _gtk_marshal_BOOLEAN__BOXED ()
#18 0x62744949 in g_type_class_meta_marshal () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#19 0x62744102 in g_closure_invoke () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#20 0x627586fd in signal_emit_unlocked_R () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#21 0x62757b28 in g_signal_emit_valist () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#22 0x62757fa6 in g_signal_emit () from /cygdrive/c/progra~1/ethereal/libgobject-2.0-0.dll
#23 0x00e0e49b in gtk_widget_event_internal ()
#24 0x00cfed6c in gtk_propagate_event ()
#25 0x00cfda26 in gtk_main_do_event ()
#26 0x003bea0e in gdk_event_dispatch ()
#27 0x672de67e in g_main_dispatch () from /cygdrive/c/progra~1/ethereal/libglib-2.0-0.dll
#28 0x672dec9f in g_main_context_iterate () from /cygdrive/c/progra~1/ethereal/libglib-2.0-0.dll
#29 0x672db959 in g_main_loop_run () from /cygdrive/c/progra~1/ethereal/libglib-2.0-0.dll
#30 0x00cfd109 in gtk_main ()
#31 0x0068212c in libpangowin32_1_0_0_dll_iname ()
#32 0x0068285f in libpangowin32_1_0_0_dll_iname ()
#33 0x0067f9c6 in libpangowin32_1_0_0_dll_iname ()
#34 0x77e814c7 in KERNEL32!GetCurrentDirectoryW () from /cygdrive/c/WINDOWS/system32/kernel32.dll
(gdb)

Attachment: dfilter_expr_dlg.c.diff
Description: Binary data