Ethereal-dev: Re: [Ethereal-dev] Patch to find summary data

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Thu, 18 Sep 2003 12:30:49 -0700

On Sep 18, 2003, at 8:55 AM, Greg Morris wrote:

The current find summary window will not find specific NCP info added with the infostring value from ncp2222.py. Need to change the line epan_dissect_new(TRUE, TRUE) in function match_summary_line().

That change causes it to build the protocol tree and to construct the text for all protocol tree items.

Neither of those should affect the summary line, which is what's being searched; if the setting of those flags *does* affect what goes into the summary line, that's a bug in the dissector. (Yes, I know, it affects whether you try to dissect the entire packet, which affects whether the "[Short Frame]", "[Malformed Packet]", etc. tags are put into the summary line, but the only way to fix that would be to generate the protocol tree when you're generating the summary line, which is expensive.)

If you're referring to the stuff in, for example, "dissect_ncp_request()", after the "Construct the info string if necessary" comment, that code needs *NOT* to be inside "if (ncp_tree)" - *NO* code that modifies any column should be inside "if (we're constructing a protocol tree)".