Ethereal-dev: Re: [Ethereal-dev] OSI Session dissector in the works

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: "Sid Sid" <ysidelnikov@xxxxxxxxxxx>
Date: Tue, 09 Sep 2003 08:34:06 +0000
> IMHO,there are not any reassembling code regarding COTP in osi_tp too. Only
> for CLNP.

Again, that's in the current CVS version.  If you're going to be
developing an OSI session-layer dissector, you should be using the
current CVS version of Ethereal, or should wait for the next release.

Sorry, my mistake.
Now I've got recent version. But something is still wrong with reassembling segmentent COTP PDUs. Please, have a look to attached capture file - clnp_.I mean frames 8-16.Frame 8 is the first and frame 16 last COTP segmented PDUs.
Let's see packet-clnp.c :
if (cotp_reassemble) {
   fragment_length = tvb_length(next_tvb);
   fd_head = fragment_add_seq_check(next_tvb, 0, pinfo, dst_ref,
				     cotp_segment_table,
				     cotp_reassembled_table,
				     tpdu_nr,
				     fragment_length, fragment);
   if (fd_head) {
     if (fd_head->next) {
!!!!!!!!!!!!!<--------------- NEVER GOES this way -------->>>>>>
	/* This is the last packet */

Of course, "Reassemble segmented COTP datagram" is on.
So I always have only current segmented PDU when SES dissector has been called.

What is wrong ?
Thank you.
Yuriy.

_________________________________________________________________
The new MSN 8: smart spam protection and 2 months FREE* http://join.msn.com/?page=features/junkmail

Attachment: clnp_
Description: Binary data