["Greg Morris" <GMORRIS@xxxxxxxxxx>]

Well, I just did a CVS update and the endpoint talkers match selected seems to grab the wrong data from the clist. I selected Ethernet, and then the entry with the highest packet count, right clicked and selected match display filter, selected, and then EP1 <-> EP2. The wrong filter was set. I expected eth.addr==00:05:31:dd:54:0a && eth.addr==00:06:29:89:1b:96 which is what I had highlighted. Instead I received eth.addr==00:05:31:dd:54:0a && eth.addr==ff:ff:ff:ff:ff:ff which was in the list but not highlighted.

 

It seems to work correctly if I do not click on a different item in the list and only choose the default highlighted item.

 

F.Y.I. - In the showconversation.c file I had to use the following to force Ethereal to refilter and display the information based on the current display filter. I don't know if this is possible for the same code but you might investigate.

 

/* What to do when OK button is selected */
static void
proto_ok_cb(GtkWidget *ok_bt _U_, gpointer parent_w)
{
  gtk_entry_set_text(GTK_ENTRY(filter_te), global_filter); /* echo filter to main filter dialog */
  filter_packets(&cfile, global_filter); /* Refilter packet trace with new filter */
  gtk_widget_destroy(parent_w);
}

Greg 

>>> sahlberg@xxxxxxxxxxxxxxxxx 8/27/2003 6:10:22 AM >>>

sahlberg    2003/08/27 07:10:22 CDT

  Modified files:
    gtk                  endpoint_talkers_eth.c
                         endpoint_talkers_fc.c
                         endpoint_talkers_ip.c
                         endpoint_talkers_ipx.c
                         endpoint_talkers_table.c
                         endpoint_talkers_table.h
                         endpoint_talkers_tcpip.c
                         endpoint_talkers_tr.c
                         endpoint_talkers_udpip.c
  Log:
   Updates for the endpoint talkers thing
 
  The table now has a popup menu with
     Match display filter
           Selected
                 EP1 <-> EP2
                 EP1 --> EP2
                 EP1 <-- EP2
                 EP1 --> ANY
                 EP1 <-- ANY
                 EP2 --> ANY
                 EP2 <-- ANY
            Not Selected
                 ...
            ...
      Prepare Display Filter
            ...
 
  Self explanatory.
 
  Now the bad news.
  I set the display filter box in the main window and i call redissect_packet
  which redissects the packet list   but the displayfilter does not take
  or affect the main window until i click  the apply button.
 
  Some signal needs to be raised to some object me thinks.
 
  Please feel free to fix it if you know what is missing.
 
  Revision  Changes    Path
  1.6       +10 -2     ethereal/gtk/endpoint_talkers_eth.c
  1.6       +10 -2     ethereal/gtk/endpoint_talkers_fc.c
  1.7       +11 -4     ethereal/gtk/endpoint_talkers_ip.c
  1.5       +10 -2     ethereal/gtk/endpoint_talkers_ipx.c
  1.4       +433 -5    ethereal/gtk/endpoint_talkers_table.c
  1.3       +6 -2      ethereal/gtk/endpoint_talkers_table.h
  1.8       +13 -2     ethereal/gtk/endpoint_talkers_tcpip.c
  1.7       +10 -2     ethereal/gtk/endpoint_talkers_tr.c
  1.8       +12 -2     ethereal/gtk/endpoint_talkers_udpip.c

_______________________________________________
Ethereal-cvs mailing list
Ethereal-cvs@xxxxxxxxxxxx
http://www.ethereal.com/mailman/listinfo/ethereal-cvs