Ethereal-dev: Re: [Ethereal-dev] Patch: Allow CHDLC and PPP_HDLC dissectors to share FCS decod

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 25 Aug 2003 22:54:02 -0700
On Tue, Aug 26, 2003 at 05:11:51PM +1200, Jesper Peterson wrote:
> Attached is a patch which extracts the FCS decoding section of the PPP_HDLC 
> dissector to allow the CHDLC dissector to use the same routine. The 
> ppp_options used for preferences has been renamed to fcs_options and exported 
> via packet-ppp.h so CHDLC gets a separate (but identical) FCS preference. This 
> means prefs.h has to be included before packet-ppp.h so a couple of ppp 
> related files (packet-{gtp,null,raw,vj}.c) had their includes slightly 
> re-arranged.

Checked in (along with a change to make the 32-bit FCS for PPP/CHDLC use
the same routine used for 802.11 CRCs and, now, Ethernet CRCs).