Ethereal-dev: RE: [Ethereal-dev] Updated enip dissector

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: "Joakim Wiberg" <jow@xxxxxxxxxxxxxxxx>
Date: Fri, 8 Aug 2003 10:00:03 -0500
1. I'm not sure I understand what you mean by this, I used diff -uNr my-tree
ethereal-cvs-tree.

3. Sould all "local" functions be declared using static?


-----Original Message-----
From: Guy Harris [mailto:guy@xxxxxxxxxxxx]
Sent: den 7 augusti 2003 16:52
To: jow@xxxxxxxxxxxxxxxx
Cc: ethereal-dev@xxxxxxxxxxxx
Subject: Re: [Ethereal-dev] Updated enip dissector



On Thursday, August 7, 2003, at 2:38 PM, Joakim Wiberg wrote:

> This patch solves some minor issues that in packet-enip.c.

1) The patch was a "reverse order" patch, with the first version being
the newer version, which causes patch to warn that the it might be
reversed and to ask you if you want to assume "-R".

2) The RCS ID goes backwards if you apply it with "-R".

3) "add_cip_data()" should be static.

4) It gives some unused variable warnings with GCC 3.3:

packet-enip.c:1213: warning: unused variable `mr_data_item'
packet-enip.c:1222: warning: unused variable `uncon_add_stat_size'

(line numbers may differ).