Ethereal-dev: Re: [Ethereal-dev] [PATCH] decouple dcerpc authentication from packet-dcerpc.c

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Tue, 15 Jul 2003 16:16:20 -0700

On Monday, July 14, 2003, at 10:21 PM, Tim Potter wrote:


Caveats:
- There are still a few issues to work out with the value_string for the 
    DCE_C_RPC_AUTHN_PROTOCOL_* constants.
A general mechanism for defining value_strings at run time might be useful.
- SPNEGO and secure channel dissections are broken but should be easy to 
    convert to the new interface.


They should be converted.
Again I'm putting this out there for anyone (probably Guy (-:) to comment 
on.
The DCE_C_AUTHN_LEVEL_xxx #defines should probably all be moved to "packet-dcerpc.h", to keep them together, even if not all of them are used in calls to "register_dcerpc_auth_subdissector". The DCE_C_RPC_AUTHN_PROTOCOL_xxx values should probably be moved as well.