Ethereal-dev: Re: [Ethereal-dev] kadmin dissector (resend)

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <guy@xxxxxxxxxx>
Date: Fri, 2 May 2003 14:59:31 -0700
On Fri, May 02, 2003 at 12:17:50PM -0400, Schene_Tony@xxxxxxx wrote:
> Here is a patch which contains support for AUTH_GSSAPI.

Checked in.

> So to avoid as much confusion as possible, when an
> AUTH_GSSAPI authentication message is sent, I display the AUTH_GSSAPI auth
> procedure name in the info column and the RPC tree, and "RPC" in the
> protocol column.  I also do not display the program-specific subtree in this
> case.  I admit that this is an awkward solution, but it's the least wrong
> one that I can think of.

I can't think of a better one, offhand.

> I also fixed what appears to be an "off by 4" bug on line 2122 of
> packet-rpc.c, version 1.121 (line 2274 of the patched file).

I replaced all the "proto_item_set_len()" calls with calls to the new
"proto_item_set_end()" routine, which sets the length of the item based
on a tvbuff/end offset pair ("end offset" meaning "offset right past the
end", in this context) rather than a length.